[FFmpeg-devel] [PATCH] libvpx: deadline & profile support

[Michael Niedermayer]

On Mon, Jun 14, 2010 at 10:36:29PM +0200, Rafa?l Carr? wrote:
> On Mon, 14 Jun 2010 16:20:20 -0400
> James Zern <jzern at google.com> wrote:
> 
> > Index: libavcodec/libvpxenc.c
> > ===================================================================
> > --- libavcodec/libvpxenc.c	(revision 23607)
> > +++ libavcodec/libvpxenc.c	(working copy)
> > @@ -276,7 +276,29 @@ static av_cold int vp8_init(AVCodecConte
> > +    if (avctx->profile != FF_PROFILE_UNKNOWN)
> > +        enccfg.g_profile = avctx->profile;
> 
> avcodec.h only defines AAC and H264 profiles, so the meaning of
> enccfg.g_profile is private?
> 
> note that mpeg1/2 video decoder uses 'profile == 0' for 4:2:2 chroma and
> 4 for 4:2:0. value 1 is "High" profile.
> 
> profile is also used in mpeg4 video encoder with private values (i
> suppose they come from the spec)
> 
> 
> Shouldn't profile values be documented, and moved near the codec id
> definition to which they apply (see attachment) ?
> 
> -- 
> Rafa?l Carr?

>  avcodec.h |   28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> c9ea6e81887de3d797638c5466619f9dbe7121cc  move-profile-defines.diff

ive no strong oppinion on this bikeshed patch, there are disadvantages no
mater where the values are moved but if you want a yes/no id say lets
leave it where it is


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100711/70163785/attachment.pgp>