[FFmpeg-devel] [PATCH] add avsubtitle_free

[Michael Niedermayer]

On Sat, Jul 10, 2010 at 11:46:34AM +0200, Reimar D?ffinger wrote:
> On Sat, Jul 03, 2010 at 11:16:32AM +0200, Reimar D?ffinger wrote:
> > applications really shouldn't have to duplicate free functions.
> > This also should make it easier for us to extend AVSubtitle, at least
> > the data array without causing memleaks at the very least.
> 
> Ping? I'd rather not have to duplicate this in MPlayer.
> And updated to actually free everything.

sorry for the delay, i wanted to think about the API a bit
as with video frames pretty much are allocated and freed by the decoder
through get/release_buffer() which could be callbacks to the user app.

do we want subtitles to be handled differently?
if yes, then your patch is ok
if no, well ...

it might make sense if our subtitle decoders could via a get_buffer()
equivalent draw subtitles directly into some player buffer that will
be displayed. But maybe this becomes too convoluted, i dont know

but as said ive not had time to think about this as much as one
should to make a good suggestion about which way to go.

also if there ever is a subtitle decoder that has P frames, a
system closer to video codecs will be more efficient.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100710/8774b0cb/attachment.pgp>