[FFmpeg-devel] [PATCH] Fix warning about decode_mb_skip (in libavcodec/h264.h)

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Tue, Jul 06, 2010 at 10:29:03AM +0100, M?ns Rullg?rd wrote:
>> Diego Biurrun <diego at biurrun.de> writes:
>> 
>> > On Fri, Jul 02, 2010 at 12:49:03AM +0200, Michael Niedermayer wrote:
>> >> On Thu, Jul 01, 2010 at 03:45:16PM -0700, Eli Friedman wrote:
>> >> > On Thu, Jul 1, 2010 at 3:39 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >> > > On Tue, Jun 29, 2010 at 10:06:12PM -0700, Eli Friedman wrote:
>> >> > >> Patch attached; fixes warning "'decode_mb_skip' defined but not used".
>> >> > >> ?As far as I can tell, doesn't have any significant effect on the
>> >> > >> generated code, since the function in question gets inlined either
>> >> > >> way.
>> >> > >
>> >> > > feel free to add av_unused
>> >> > 
>> >> > Sure; updated patch attached.
>> >> 
>> >> ok
>> >
>> > Applied.
>> 
>> This is ridiculous.  I wish Michael could respond to my other message
>> in this thread.
>
> Been there, done that - you will remember that I tried to come up with
> a proper fix before, I was not successful...

So you'd rather cover it up and hope everybody forgets?  The code is
wrong and must be fixed.

-- 
M?ns Rullg?rd
mans at mansr.com