[FFmpeg-devel] [PATCH]Only set attribute_align_arg for x86_32

Eli Friedman eli.friedman
Tue Jul 6 05:51:40 CEST 2010


2010/7/3 M?ns Rullg?rd <mans at mansr.com>:
> Carl Eugen Hoyos <cehoyos at ag.or.at> writes:
>
>> M?ns Rullg?rd <mans <at> mansr.com> writes:
>>
>>> > ?#ifndef attribute_align_arg
>>> > -#if (!defined(__ICC) || __ICC > 1110) && AV_GCC_VERSION_AT_LEAST(4,2)
>>> > +#if ARCH_X86_32 && (!defined(__ICC) || __ICC > 1110) &&
>> ?AV_GCC_VERSION_AT_LEAST(4,2)
>>> > ?# ? ?define attribute_align_arg __attribute__((force_align_arg_pointer))
>>> > ?#else
>>> > ?# ? ?define attribute_align_arg
>>>
>>> The warning is annoying, but it serves a purpose.
>>
>> Could you elaborate?
>
> An aligned stack is beneficial on any CPU, not only x86.

Sure, but force_align_arg_pointer doesn't mean "align the stack"; it
means "recover from a misaligned stack", and that is only expected to
happen on x86-32.

-Eli



More information about the ffmpeg-devel mailing list