[FFmpeg-devel] [PATCH] Fix compilation of FASTDIV() with llvm-gcc on x86_64
Måns Rullgård
mans
Mon Jul 5 19:59:35 CEST 2010
David Conrad <lessen42 at gmail.com> writes:
> On Jul 5, 2010, at 1:45 PM, M?ns Rullg?rd wrote:
>
>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>>
>>> On Mon, Jul 05, 2010 at 02:54:09PM +0100, Mans Rullgard wrote:
>>>> LLVM requires matching input and output asm parameters to have the
>>>> same type. For the FASTDIV macro, an (int) cast on the input fixes
>>>> this trivially.
>>>
>>> Uh, where is a different type than int used with FASTDIV?
>>> I am not at all convinced those uses are really correct.
>>
>> vorbis_dec.c line 1329.
>
> This could be changed to int if it helps; neither operand is greater
> than 24 bits unsigned.
Making it a plain unsigned works. I never understood why that file is
so obsessive with the _fast types.
--
M?ns Rullg?rd
mans at mansr.com
More information about the ffmpeg-devel
mailing list