[FFmpeg-devel] [PATCH] GSM 6.10 audio decoder

[Michael Niedermayer]

On Mon, Jul 05, 2010 at 09:47:02AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Sat, Jul 3, 2010 at 7:03 PM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de> wrote:
[...]

> > +AVCodec gsm_decoder = {
> > +    "gsm",
> > +    AVMEDIA_TYPE_AUDIO,
> > +    CODEC_ID_GSM,
> > +    sizeof(GSMContext),
> > +    gsm_init,
> > +    NULL,
> > +    NULL,
> > +    gsm_decode_frame,
> > +    .long_name = NULL_IF_CONFIG_SMALL("GSM"),
> > +};
> > +
> > +AVCodec gsm_ms_decoder = {
> > +    "gsm_ms",
> > +    AVMEDIA_TYPE_AUDIO,
> > +    CODEC_ID_GSM_MS,
> > +    sizeof(GSMContext),
> > +    gsm_init,
> > +    NULL,
> > +    NULL,
> > +    gsm_decode_frame,
> > +    .long_name = NULL_IF_CONFIG_SMALL("GSM Microsoft variant"),
> > +};
> 
> You could use a macro here to decrease source code size.

i think thats obfuscating it a bit too much but that are just my 10cent
its the maintainers decission of course not mine

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100705/16fdcb5b/attachment.pgp>