[FFmpeg-devel] [PATCH] H.264 : lowres isn't supported currently so treat a non-zero value as an error.

[Michael Niedermayer]

On Sun, Jul 04, 2010 at 06:25:06PM +0000, Carl Eugen Hoyos wrote:
> Jai Menon <jmenon86 <at> gmail.com> writes:
> 
> > diff --git a/libavcodec/h264.c b/libavcodec/h264.c
> > index 1054286..5d9ef89 100644
> > --- a/libavcodec/h264.c
> > +++ b/libavcodec/h264.c
> > @@ -903,6 +903,11 @@ av_cold int ff_h264_decode_init(AVCodecContext *avctx){
> >      H264Context *h= avctx->priv_data;
> >      MpegEncContext * const s = &h->s;
> > 
> > +    if (avctx->lowres) {
> 
> Since this affects many decoders (and for the remaining ones, there usually is a
> limit, and they crash if it is exceeded), could this be solved more generally.
> 
> My naive idea was to add the maximum value to struct AVCodec, and assume 0 as
> default value.

ok, as int8_t probably would be best to avoid wasting space

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100704/b3dd8bf1/attachment.pgp>