[FFmpeg-devel] [PATCH] Fix warning in av_rescale_rnd (in libavutil/mathematics.c)

[Michael Niedermayer]

On Sat, Jul 03, 2010 at 01:02:55PM +0200, Reimar D?ffinger wrote:
> On Sat, Jul 03, 2010 at 12:17:25PM +0200, Michael Niedermayer wrote:
> > On Sat, Jul 03, 2010 at 12:42:08AM -0700, Eli Friedman wrote:
> > > Patch attached.  Fixes warning "comparison of unsigned expression >= 0
> > > is always true".
> > 
> > god damn, its a assert(), what is wrong with asserting that a variable
> > is unsigned or if signed is positive. Why is gcc so retarded
> 
> Umm, gcc just can't know your intention. I have seen this kind of
> thing quite a few times where it was an actual bug because someone
> forgot to make a variable signed.
> That said, casting the value to int before the comparison should
> avoid the warning...

if so, feel free to do this

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100703/22f727da/attachment.pgp>