[FFmpeg-devel] [PATCH] Altivec-optimized MP3 windowing
Vitor Sessak
vitor1001
Thu Jul 1 23:37:10 CEST 2010
On 07/01/2010 10:15 PM, Luca Barbato wrote:
> On 07/01/2010 09:44 PM, Vitor Sessak wrote:
>> $subj, I know very little about altivec, so comments are very welcome.
>>
>> -Vitor
>
> + const vector float *win1a = (const vector float *) win1;
> + const vector float *win2a = (const vector float *) win2;
> + const vector float *bufa = (const vector float *) buf;
> + vector float *sum1a = (vector float *) sum1;
> + vector float *sum2a = (vector float *) sum2;
>
> There are guarantees about alignment?
>
> vec_ld takes any pointer as argument iirc.
>
> + v0 = vec_xor(v0, v0);
> + v4 = vec_xor(v4, v4);
>
> altivec has 32 registers, use them =)
>
> Beside that nothing seems particularly wrong after a quick glance =)
Discussed on IRC and applied.
-Vitor
More information about the ffmpeg-devel
mailing list