[FFmpeg-devel] [PATCH] Add AMR-NB decoder, next try

Martin Storsjö martin
Sun Jan 31 21:45:59 CET 2010

On Sat, 30 Jan 2010, Vitor Sessak wrote:

> All comments fixed, new patch attached.

When testing this in valgrind, I noticed that decode_fixed_sparse only 
initializes the no_repeat_mask field for some modes, but not for all, 
triggering warnings for using uninitialized data in ff_set_fixed_vector 
and ff_clear_fixed_vector.

I'm not familiar enough with the code to say if this a real problem 
though. (This field never seems to be set to anything else than zero, as 
far as I can see?)

After initializing this field to zero, decoding all AMR modes went fine 
without any other valgrind warnings.

// Martin

More information about the ffmpeg-devel mailing list