[FFmpeg-devel] [PATCH] forbid strcpy

Ronald S. Bultje rsbultje
Sat Jan 30 17:02:34 CET 2010


On Jan 30, 2010, at 10:34 AM, Reimar D?ffinger  
<Reimar.Doeffinger at gmx.de> wrote:
> Hello,
> this will cause a lot of build failures, so can't be applied as is,  
> but
> please all maintainers: either remove any strcpy uses from your copy  
> or
> complain now, or I take the freedom to modify your code without  
> asking.

This is not ok, strcpy() is fine and faster in a lot of places where  
we copy between internal buffers. There is nothing wrong with that.

Forbiddig strncpy() or modifying wrong uses of strcpy() is ok with me  


More information about the ffmpeg-devel mailing list