[FFmpeg-devel] [PATCH] remove ap->[audio|video]_codec_id usage from lavf

Michael Niedermayer michaelni
Thu Jan 28 16:55:09 CET 2010


On Thu, Jan 28, 2010 at 09:24:16PM +0530, Jai Menon wrote:
> On Thu, Jan 28, 2010 at 5:27 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Thu, Jan 28, 2010 at 03:18:06PM +0530, Jai Menon wrote:
> >> On Thu, Jan 28, 2010 at 11:51 AM, Jai Menon <jmenon86 at gmail.com> wrote:
> >> > Hi,
> >> >
> >> > Since AVFormatParameters::[audio|video]_codec_id are slated for
> >> > removal at next major bump, maybe we could stop using them. regression
> >> > tests pass.
> >>
> >> Here are the changes to ffmpeg.c as well.
> >
> >> About the
> >> pgmyuv_compatibility hack, does that even work currently? i think it
> >> would still error out when no -vcodec opt is passed, which seems to be
> >> the case when -fmt pgmyuv is used. maybe the codec_id lookup can be
> >> avoided if fmt is pgmyuv...
> >
> > i think you have to move that below ?the code that sets ic->video_codec_id
> 
> Yeah, i guess i was reading the wrong diff.
> patch attached.
> 
> -- 
> Jai Menon

>  ffmpeg.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 43d1189ddae47ebfcd671828d61f86a813d95a57  remove_ap_codec_id_ffmpeg.c.patch

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100128/ba39d55a/attachment.pgp>



More information about the ffmpeg-devel mailing list