[FFmpeg-devel] [PATCH] WMA Voice decoder

[Vitor Sessak]

Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Jan 25, 2010 at 4:34 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
>> On Mon, Jan 25, 2010 at 4:32 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>>> On Mon, Jan 25, 2010 at 4:29 PM, Vitor Sessak <vitor1001 at gmail.com> wrote:
>>>> You mean making AMRFixed.pitch_lag a vector? Fine to me...
>>> It would only have two values, pitch or 0.
>>>
>>> I was more thinking of introducing a one-bit flag in addition to y and
>>> x. We could make x unsigned and :31 to keep bitsize the same.
>> Fine to me too...
> 
> Another one; x can be <0 for me, which means "increase by pitch_lag
> until >=0". Can we somehow extend ff_set_fixed_vector() to do that for
> me (although that'd require a if x >= 0 or so in the inner loop, which
> might be bad)?

I find this an ugly design feature of WMAVoice and I'd rather it'd not 
go to common code.

-Vitor