[FFmpeg-devel] [PATCH] Enable proper IPv6 functions on windows

Ronald S. Bultje rsbultje
Fri Jan 22 16:37:19 CET 2010


Hi,

On Fri, Jan 22, 2010 at 3:22 AM, Martin Storsj? <martin at martin.st> wrote:
> Ping - any opinions on this one - Ramiro, Ronald?

> +    int (WSAAPI *win_getnameinfo)(const struct sockaddr *sa, socklen_t salen,
> +                                  char *host, DWORD hostlen,
> +                                  char *serv, DWORD servlen, int flags);
> +    HMODULE ws2mod = GetModuleHandle("ws2_32.dll");
> +    win_getnameinfo = GetProcAddress(ws2mod, "getnameinfo");
> +    if (win_getnameinfo)
> +        return win_getnameinfo(sa, salen, host, hostlen, serv, servlen, flags);

Sorry, I didn't follow the discussion very much...

Shouldn't the function pointer variable (in all functions) not be
static? Now you load it every time which sounds like a huge
time-waster to me. Otherwise looks ok to me.

Ronald



More information about the ffmpeg-devel mailing list