[FFmpeg-devel] Regression: r20954-5 broke threads auto in libx264

Jason Garrett-Glaser darkshikari
Wed Jan 20 22:50:07 CET 2010

On Wed, Jan 20, 2010 at 1:44 PM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Wed, Jan 20, 2010 at 01:13:25PM -0800, Jason Garrett-Glaser wrote:
>> If nobody can come up with a reasonable fix for this in the next day
>> or two, I will disconnect the threads option in libx264.c, forcing it
>> to auto in all cases.
> I'd suggest you consider to only remap some value, e.g. <= 1 to auto.

Yeah, that's probably better, but still misleading.  I'd prefer an actual fix.

Mans's fix above doesn't seem to work; ffmpeg simply closes instantly
with no video having been output.  x264_encoder_open is called, but
x264_encoder_close isn't.  This is the same thing that happened to me
when I reverted 20955 but not 20954.

Dark Shikari

More information about the ffmpeg-devel mailing list