[FFmpeg-devel] [PATCH] ff_scalarproduct_float_sse

[Michael Niedermayer]

On Wed, Jan 20, 2010 at 02:48:57PM +0000, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Tue, Jan 19, 2010 at 11:42:40PM -0500, Alex Converse wrote:
> >> This cause a >50% decrease in SBR decode time.
> >> 
> >> For the time being it can help in the other places where
> >> scalarproduct_float() is used.
> >> 
> >> Regards,
> >> Alex Converse
> >
> >>  dsputil_mmx.c    |    5 +++++
> >>  dsputil_yasm.asm |   25 +++++++++++++++++++++++++
> >
> > Would you mind to avoid yasm and use gcc asm instead ?
> >
> > I have no problem with yasm as such but gcc asm is more portable and
> > can be integrated with C code if we ever want that.
> 
> I have to disagree.  Just look at how many FATE targets broke with
> your change to h264_loop_filter_strength_mmx2 yesterday.  Several
> compilers are still failing to build it.

One of the optimizations that should be tried for h264 is to compile
the code with templates and directly integrate MMX/SSE* without calls.
Using yasm would make this impossible.
If the compilation failures bother someone the commits that caused them
could be reverted (and the fast loop filter disabled for b frames)
until i have time to look at them.


> 
> I'm not aware of any serious OS on which yasm doesn't run, so the
> portability argument doesn't hold water.

well that was just one argument ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100120/94c66de6/attachment.pgp>