[FFmpeg-devel] [PATCH] RTSP muxer, round 3

[Ronald S. Bultje]

Hi,

On Wed, Jan 20, 2010 at 5:36 AM, Martin Storsj? <martin at martin.st> wrote:
> On Tue, 19 Jan 2010, Ronald S. Bultje wrote:
>> > +++ b/libavformat/rtsp.c
>> > @@ -926,9 +926,11 @@ static int rtsp_read_reply(AVFormatContext *s, RTSPMessageHeader *reply,
>> > ? ? ?return 0;
>> > ?}
>> >
>> > -static void rtsp_send_cmd_async(AVFormatContext *s,
>> > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?const char *cmd, RTSPMessageHeader *reply,
>> > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?unsigned char **content_ptr)
>> > +static void rtsp_send_cmd_async_content(AVFormatContext *s,
>> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?const char *cmd, RTSPMessageHeader *reply,
>> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?unsigned char **content_ptr,
>> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?unsigned char *send_content,
>>
>> const unsigned char *.
>
> Ok, changed. However, this gives a warning:
>
> libavformat/rtsp.c:1018: warning: passing argument 2 of 'url_write'
> discards qualifiers from pointer target type
>
> (since url_write takes a non-const pointer)

Oi, shit. We should fix that. (I don't mean "you" specifically here,
just mean it's a bug in general.)

(Will look at the rest in a bit.)

Cheers,
Ronald