[FFmpeg-devel] What is missing for working AVFMT_FLAG_NONBLOCK?

Luca Abeni lucabe72
Sun Jan 17 20:20:37 CET 2010


On Sun, 2010-01-17 at 19:27 +0200, aviad rozenhek wrote:
> >
> >
> > not reviewable, mixes cosmetics & functional changes
> >
> >
> the previous patch removed the the for(;;) which becomes unnecessary, that's
> why there's indentation changes.
> attached is an updated patch that changes just one line, but leaves the
> redundant for loop block in place.

First of all, thanks for your patch.

I see other people already commented about splitting the patch and
separating the cosmetic changes.
Few more comments:
1) I think the patch is trying to do the right thing. If you provide a
clean (see other people's comments about cosmetic vs functional changes,
etc...) set of tested patches, I'll apply it
2) I am not sure if there are some pending patches for udp.c (I've been
mostly offline in the latest days, so I do not know the status of the
IPv6 patches). I think this change should be committed after the IPv6
thing is done (to avoid conflicts, etc...)
3) I believe that with this change the select() timeout can be chaged
from 100ms to 0


More information about the ffmpeg-devel mailing list