[FFmpeg-devel] [PATCH] H.264: faster skip decoding

[Jason Garrett-Glaser]

On Sat, Jan 16, 2010 at 7:17 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sat, Jan 16, 2010 at 02:37:14PM -0500, Jason Garrett-Glaser wrote:
>> On Sat, Jan 16, 2010 at 2:34 PM, Jason Garrett-Glaser
>> <darkshikari at gmail.com> wrote:
>> > On Sat, Jan 16, 2010 at 2:25 PM, Jason Garrett-Glaser
>> > <darkshikari at gmail.com> wrote:
>> >> On a very skip-heavy source:
>> >>
>> >> After:
>> >> real ? ?12m52.048s
>> >> user ? ?10m6.360s
>> >> sys ? ? 1m53.584s
>> >>
>> >> Before:
>> >> real ? ?13m21.203s
>> >> user ? ?10m28.450s
>> >> sys ? ? 1m53.646s
>> >>
>> >> Dark Shikari
>> >>
>> >
>> > Ugh, it seems the hashes don't match, despite the fact that this patch
>> > really shouldn't break anything. ?Ideas are welcome as to what's wrong
>> > here, because the idea seems to be sound.
>> >
>> > Dark Shikari
>> >
>>
>> And the problem is deblocking. ?Ignore this patch, it doesn't work
>> with ffmpeg's deblocking model. ?Maybe if we did if(IS_SKIP(mbtype) &&
>> deblocking is off)...
>
> Iam currently trying to move the deblocing into a seperate pass

Are you sure this is a good idea?  It might be much better on L1I, but
it might be a lot worse on everything else, since everything will be
pushed out of cache and then back into cache... on the other hand, it
will allow threading with disable_deblock_idc = 1.

Dark Shikari