[FFmpeg-devel] [PATCH/RFC] Prefer getaddrinfo over gethostbyname

Måns Rullgård mans
Mon Jan 11 19:11:55 CET 2010


"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> First of all: this wouldn't even compile, because your struct
> sockaddr_storage contains no ss_family field, only an "x" field.
> That's fine with me, but probably wrong, and you might want to fix
> that. Example:
>
> #if !HAVE_STRUCT_SOCKADDR_STORAGE
> struct sockaddr_storage {
>     union {
>         struct {
>             field ss_family;
>             other fields;
>         };
>         struct sockaddr_in x;
>     };
> };
> #endif
>
> Although this'd compile, there was also some discussion on whether
> this is fine b/c it might be a gcc extension, not sure.

That would _not_ compile simply because it is not standard C.  See
that other discussion for details.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list