[FFmpeg-devel] [PATCH] RTSP muxer, round 2

[Martin Storsjö]

Hi,

Here's the second round of the RTSP muxer. Now it uses chained muxers, 
so no changes to the RTP muxer was needed, and the number of patches is 
much smaller.

I've been testing and discussing this with Luca A. a bit lately, and he's 
generally quite ok with it.

Patch 1 requires the getaddrinfo/getnameinfo stuff from the other thread, 
so it shouldn't be applied until after that has entered SVN.

In patch 5, there's still some open questions on using chained muxers, on 
what parameters to copy between the original and chained AVStream and 
AVCodecContext.

This still uses the is_output flag that Ronald opposed, though. The ones 
in rtsp_open could be avoided by splitting that into two separate 
functions, sharing the common code (general setup, tcp connection opening 
and the make_setup_request loop) by splitting it out to separate 
functions. The is_output flag usage in make_setup_request could perhaps be 
avoided by making the mode value as a parameter to the function.

That leaves setting up and cleaning up the transport_priv member. Since 
everything in rtsp_parse_transport (that sets the transport and 
lower_transport parameters) is equal for both RTSP/RTP output and input, I 
don't feel that a e.g. RTP_OUT and RTP_IN value for transport (that was 
suggested) would be suitable. So therefore I still feel that the current 
is_output flag is the best solution to this issue.

Regards,
// Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-sure-the-destination-address-is-written-as-an-I.patch
Type: text/x-diff
Size: 2884 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100111/8eb58a3f/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-internal-rtsp-functions-for-doing-requests-that-.patch
Type: text/x-diff
Size: 3089 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100111/8eb58a3f/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-a-RTSPClientState-for-recording.patch
Type: text/x-diff
Size: 855 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100111/8eb58a3f/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Add-a-flag-for-storing-the-direction-of-the-rtsp-ses.patch
Type: text/x-diff
Size: 752 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100111/8eb58a3f/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Create-AVFormatContext-objects-as-private-transport-.patch
Type: text/x-diff
Size: 4904 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100111/8eb58a3f/attachment-0004.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Add-proper-mode-to-output-setup-requests.patch
Type: text/x-diff
Size: 1121 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100111/8eb58a3f/attachment-0005.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Add-a-function-for-doing-the-RECORD-RTSP-request.patch
Type: text/x-diff
Size: 1273 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100111/8eb58a3f/attachment-0006.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Split-rtsp_read_header-into-a-reusable-function-rtsp.patch
Type: text/x-diff
Size: 1166 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100111/8eb58a3f/attachment-0007.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Enable-rtsp_open-to-work-for-output-too.patch
Type: text/x-diff
Size: 3556 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100111/8eb58a3f/attachment-0008.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Add-an-RTSP-muxer.patch
Type: text/x-diff
Size: 6600 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100111/8eb58a3f/attachment-0009.patch>