[FFmpeg-devel] [PATCH 0/5][RFC] Speed up AAC decoder

Robert Swain robert.swain
Mon Jan 11 14:34:41 CET 2010


On 11/01/10 13:37, Mans Rullgard wrote:
> This patch series speeds up the AAC decoder by 25-50% on Cortex-A8 and
> by 20-30% on Core i7.
> Some of the more obscure parts certainly need a few comments, which I
> will add if there are no objections to this approach.

I've looked through to see what you've done and on the whole it looks 
good to me.

Personally I prefer some parentheses around not-so-well-known operator 
precedence ambiguities for clarification and some more vertical 
alignment of assignments, but that's just cosmetics.

I would request that Alex run this code through the compliance tests to 
make sure we have no regressions, if he has time.

Otherwise, a very nice performance boost. Good stuff! :)

Best regards,

More information about the ffmpeg-devel mailing list