[FFmpeg-devel] [PATCH] H264 DXVA2 implementation

[Reimar Döffinger]

On Sun, Jan 10, 2010 at 03:01:25PM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> 
> > On Sun, Jan 10, 2010 at 01:21:47PM +0000, M?ns Rullg?rd wrote:
> >> Ramiro Polla <ramiro.polla at gmail.com> writes:
> >> 
> >> > On Sat, Jan 9, 2010 at 9:46 PM, Laurent Aimar <fenrir at videolan.org> wrote:
> >> >> New patch (v5) attached.
> >> >
> >> > j-b pointed me to the vlc buildbot where this doesn't compile under
> >> > "-std=c99" (which is set by default in FFmpeg). I'm no C guru and I'm
> >> > quite tired right now, but it seems you can't use anonymous unions in
> >> > your dxva2api.h, such as:
> >> >
> >> > typedef struct {
> >> >     union {
> >> >         struct {
> >> >             UCHAR Index7Bits     : 7;
> >> >             UCHAR AssociatedFlag : 1;
> >> >         };
> >> >         UCHAR bPicEntry;
> >> >     };
> >> > } DXVA_PicEntry_H264;
> >> 
> >> WTF?  How would you even begin to access those fields?
> >
> > It's a Microsoft/GNU extension.
> > DXVA_PicEntry_H264.Index7Bits
> > accesses right into the union/struct
> 
> What's the point of that?  Why not put them directly in the outer
> struct if you don't want a name?

That obviously doesn't work for the union.