[FFmpeg-devel] [PATCH] H264 DXVA2 implementation

[Michael Niedermayer]

On Thu, Jan 07, 2010 at 11:19:26PM +0100, Laurent Aimar wrote:
> Hi,

Hi

just wanted to say iam very happy to see some h264 related contributions :)
ill do a real review of the patch later when i have more time, for now ill
leave it to reimar and others ...

[...]

> > 
> > > +    switch (h->slice_type) {
> > > +    case FF_P_TYPE:  slice->slice_type = 0; break;
> > > +    case FF_B_TYPE:  slice->slice_type = 1; break;
> > > +    case FF_I_TYPE:  slice->slice_type = 2; break;
> > > +    case FF_SP_TYPE: slice->slice_type = 3; break;
> > > +    case FF_SI_TYPE: slice->slice_type = 4; break;
> > 
> > There are no constants defined for those values?
>  They come from the specs (H264 one).

i think we have some code that maps these forward and backward already
used by the VAAPI code possibly


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100108/7db411e4/attachment.pgp>