[FFmpeg-devel] [PATCH] Make avfilter_formats_unref() handle the case where *ref is NULL

Stefano Sabatini stefano.sabatini-lala
Thu Jan 7 23:56:37 CET 2010


On date Thursday 2010-01-07 21:31:15 +0100, Michael Niedermayer encoded:
> On Thu, Jan 07, 2010 at 12:37:08AM +0100, Stefano Sabatini wrote:
> > On date Thursday 2010-01-07 00:14:54 +0100, Michael Niedermayer encoded:
> > > On Wed, Jan 06, 2010 at 11:33:38PM +0100, Stefano Sabatini wrote:
> > [...]
> > > > +fail:
> > > > +    if (formats)
> > > > +        avfilter_formats_unref(&formats);
> > > 
> > > do we need the if() ?
> > > in general functions not needing explicit NULL checks are nicer IMHO
> > 
> > Do you mean like this?
> > -- 
> > FFmpeg = Friendly Faboulous Mean Ponderous Extreme Guru
> 
> >  avfilter.h |    5 +++--
> >  formats.c  |    3 +++
> >  2 files changed, 6 insertions(+), 2 deletions(-)
> > c818d6d31da2124f8c416f0300fab638b0dd154d  make-avff-unref-manage-null.patch
> 
> ok

Applied.
-- 
FFmpeg = Foolish and Fast Meaningful Programmable Evangelical Ghost



More information about the ffmpeg-devel mailing list