[FFmpeg-devel] [PATCH] ALS: Solve Issue 1657

[Michael Niedermayer]

On Thu, Jan 07, 2010 at 01:15:20PM +0100, Thilo Borgmann wrote:
> Am 07.01.10 09:33, schrieb Reimar D?ffinger:
> > On Thu, Jan 07, 2010 at 01:19:57AM +0100, Thilo Borgmann wrote:
> >>>>>            y += MUL64(lpc_cof[sb], raw_samples[sb]);
> >>>>>
> >>>>>        *raw_samples++ -= y >> 20;
> >>>>>    }
> >>>
> >>> checking the end via raw_samples < end should be faster
> >>> (1 variable less, 1 ++ less)
> >>> also if this is on x86_64 try to make sb long instead of int this
> >>> too might help
> >>
> >> Yes and yes:
> > 
> > x86_reg would also work for mingw64
> 
> Patch attached using faster "raw_samples < end"-loop.
> 
> What still might be improved, is to type variable "sb" for different
> architectures but my question about how to do this in ffmpeg still
> remains open. Though, this might be a more general request for the
> decoder and therefore worth another patch/thread...
> 
> -Thilo

>  alsdec.c |   25 +++++++++++++++++++------
>  1 file changed, 19 insertions(+), 6 deletions(-)
> b6552e939b9152ef05bedf648876cd1a0930add0  als_issue1657_better.rev1.patch

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100107/2c668f00/attachment.pgp>