[FFmpeg-devel] [PATCH] DeluxePaint Animation playback system

[pross at xvid.org]

On Mon, Oct 19, 2009 at 10:36:11PM +0200, Michael Niedermayer wrote:
> On Sun, Oct 18, 2009 at 04:19:04PM +1100, Peter Ross wrote:
> > On Thu, Oct 15, 2009 at 07:01:28PM +0200, Diego Biurrun wrote:
> > > On Thu, Oct 15, 2009 at 07:54:05PM +1100, Peter Ross wrote:
> > > > 
> > > > +++ b/libavcodec/anm.c
> > > > @@ -0,0 +1,177 @@
> > > > +static av_cold int decode_init(AVCodecContext *avctx) {
> > > 
> > > K&R function declarations please; you use them everywhere else.
> > 
> > Ok.
> [...]

Yeah its been awhile. Updated patch encloed.

> [...]
> > +static int read_packet(AVFormatContext *s,
> > +                       AVPacket *pkt)
> > +{
> > +    AnmDemuxContext *anm = s->priv_data;
> > +    ByteIOContext *pb = s->pb;
> > +    Page *p;
> > +    int j;
> > +
> > +    if (url_feof(s->pb))
> > +        return AVERROR(EIO);
> > +
> > +    if (anm->page < 0)
> > +        return 0;
> > +
> 
> > +repeat:
> 
> maybe this could be a do/while loop which if it has no other disadvantages
> and doesnt need more lines would IMHO be clearer than a goto

do{} while adds more lines.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: anm-r6.diff
Type: text/x-diff
Size: 16066 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100108/6721159f/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100108/6721159f/attachment.pgp>