[FFmpeg-devel] [PATCH] Add an RTSP muxer

[Martin Storsjö]

On Tue, 5 Jan 2010, Luca Abeni wrote:

> On 05/01/10 00:30, Martin Storsj? wrote:
> [...]
> > > - Patch 03/24 looks ok. But maybe avf_sdp_create() should just fail if the
> > > destination address is not "rtp://"
> > > - I still have to think about patch 04/24.
> > 
> > In the RTSP/RTP setup procedure, the destination port isn't known when
> > creating the SDP, so port will inevitably be 0 here. And as far as I can
> > see from the SDP specs in RFC, a c= line is mandatory - the current code
> > in sdp.c leaves out this line if n_files == 1 and port<= 0.
> 
> Ok; so the failing case is RTSP with a single stream (audio only). Right?
> Yes, I think your patch is ok, then. I'll double look at it and commit in the
> weekend.

That would be one failing case, yes.

In my initial setup, I had one single AVFormatContext (rtsp) with any 
number of AVStreams inside, so I always hit the n_streams == 1 case.

After modifying the code to use separate AVFormatContexts for the RTP 
muxers, this case would only be hit if sending a single stream (either 
audio or video).

// Martin