[FFmpeg-devel] [PATCH] Function to parse Dirac sequence header

[David Conrad]

On Jan 1, 2010, at 4:58 PM, Michael Niedermayer wrote:

> On Tue, Dec 29, 2009 at 04:30:54PM +0100, Diego Biurrun wrote:
>> On Mon, Dec 28, 2009 at 02:10:07AM +0100, Michael Niedermayer wrote:
>>> On Wed, Nov 12, 2008 at 11:01:28PM -0500, David Conrad wrote:
>>>> On Nov 12, 2008, at 10:00 PM, Anuradha Suraparaju wrote:
>>>>> 
>>>>> This is what I am doing in my local tree.
>>>>> 
>>>>> in ffdirac_header
>>>>> -----------------
>>>>> 
>>>>> st->need_parsing = AVSTREAM_PARSE_HEADERS;
>>>>> ( This ensures that the decoder is invoked during av_find_stream_info
>>>>> call)
>>>>> 
>>>>> in ffdirac_gptopts
>>>>> 
>>>>> if (st->codec->time_base.num && st->codec->time_base.den)
>>>>> 		st->time_base = st->codec->time_base;
>>>>> 
>>>>> It appears to be an overkill to check the codec timebase and set the
>>>>> stream time base in every call to ffdirac_gptopts, but the check is
>>>>> required if we don't want to decode the Dirac sequence header in
>>>>> ffdirac_header.
>>>> 
>>>> There's still the issue that the duration isn't set; this is something that 
>>>> imo should be done when possible, which it is for nearly all ogg files.
>>>> 
>>>> At any rate I made some changes in the soc tree to this function. Updated 
>>>> version attached.
>>> 
>>>> commit b5dad233c8187289cfc674fd6a67ffdfe4734d73
>>>> Author: David Conrad <davedc at Kozue.local>
>>>> Date:   Wed Nov 12 22:42:47 2008 -0500
>>>> 
>>>>    Add a function to parse Dirac's sequence header
>>> 
>>> is this waiting for a review? applied? approved? rejected?
>>> or in need of a maintainer? if so someone should add himself to MAINTAINERS
>>> if no ffmpeg devel wants to maintain it i dont mind if someon from dirac
>>> takes over maintainership of our libdirac wraper related code
>> 
>> Shall I mail Anuradha?  Maybe she is willing to take over maintainership.
> 
> if david doesnt want to maintain it then yes

I went ahead and added myself to MAINTAINERS, though this isn't quite libschro/libdirac wrapper code (I somewhat forgot about this.)

Attached is the latest version of the patch that also exports colorspace metadata if you want to review it, I'll apply it in a few days after the needed enums are added.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ffmpeg-diracseq.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100104/dfe40e6f/attachment.txt>