[FFmpeg-devel] [RFC][PATCH] Add support for 12-bit color mode.
Sun Feb 28 00:05:37 CET 2010
Saturday 27 February 2010 18:51:19 Michael Niedermayer wrote:
> On Sat, Feb 27, 2010 at 12:58:35PM +0100, Janusz Krzysztofik wrote:
> > Any more suggetions on what can be split, and what should be kept
> > together? I'm probably not that familiar with the code to choose the way
> > to go other than splitting by subdirectory or source file.
> the unscaled "special" converters should be split off from the patches
> adding support in the generic (slower) code path.
OK, I'll try to discern these cases.
> Also all asm optimizations should be split off the pure C code so we can
> first get the C code through review and then the asm can be reviewed by the
> respective maintainers who know the specific asm.
That seems easier :).
Besides, would you rather like me to submit the resulting patches in a few
> ahh and, your patch is big, optimizing obscure combinations might not
> be worth, the generic codepath should be able to handle them.
If I create a separate patch for each one, couldn't less important just be
dropped up to your decision?
> That said i would mind less to have hundreads of unscaled converters
> for each case if they could be disabled at compile time
Doesn't it sound like a distinct task that should be covered by a separate
patch, not related to rgb12 support?
More information about the ffmpeg-devel