[FFmpeg-devel] [PATCH] Add support to input devices to ffprobe

[Reimar Döffinger]

On Sun, Feb 21, 2010 at 02:58:56PM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> 
> > On Sun, Feb 21, 2010 at 03:06:51PM +0100, Stefano Sabatini wrote:
> >> On date Sunday 2010-02-21 14:57:44 +0100, Stefano Sabatini encoded:
> >> > Hi, as in subject.
> >> 
> >> Missed config.h header, patch updated.
> >> -- 
> >> FFmpeg = Furious and Fascinating Marvellous Plastic Eretic Geisha
> >
> >> Index: ffmpeg/ffprobe.c
> >> ===================================================================
> >> --- ffmpeg.orig/ffprobe.c	2010-02-21 14:54:12.000000000 +0100
> >> +++ ffmpeg/ffprobe.c	2010-02-21 15:05:05.000000000 +0100
> >> @@ -20,6 +20,8 @@
> >>   */
> >>  
> >>  #undef HAVE_AV_CONFIG_H
> >> +#include "config.h"
> >
> > So to say it without the flaming:
> > Please include avconfig.h and if it doesn't contain what you need
> > change it to include it.
> 
> Wrong.  I presume this is for the missing log2 on freebsd.  We can't
> add that to avconfig.h since it depends on the compiler.

Huh? The change needs CONFIG_AVDEVICE, why should ffprobe need log2 (I admit
I haven't checked).