[FFmpeg-devel] [PATCH] asfenc: fix extended content header

[Michael Niedermayer]

On Sun, Feb 21, 2010 at 08:24:00AM +0100, Anton Khirnov wrote:
> On Sat, Feb 20, 2010 at 06:03:25PM +0100, Michael Niedermayer wrote:
> > 
> > >  asfdec.c |   16 +++++++++++++---
> > >  1 file changed, 13 insertions(+), 3 deletions(-)
> > > 05d0c9d611db817283bd54e08af9b1225b9c868e  0001-asfdec-don-t-try-to-read-byte-array-tags-in-extended.patch
> > > From 20f7bc0971b1df7ef80bafce3d9eddad66ff9d53 Mon Sep 17 00:00:00 2001
> > > From: Anton Khirnov <wyskas at gmail.com>
> > > Date: Thu, 18 Feb 2010 19:03:18 +0100
> > > Subject: [PATCH] asfdec: don't try to read byte array tags in extended content header.
> > > 
> > > ---
> > >  libavformat/asfdec.c |   16 +++++++++++++---
> > >  1 files changed, 13 insertions(+), 3 deletions(-)
> > 
> > i dont think you need 10 new lines to add 1 line (av_log)
> > 
> what? that patch does exactly what it says in the header, that is
> 'asfdec: don't try to read byte array tags in extended content header.'

the patch replaces if() by switch/case
the patch fixes a memleak by adding av_free (should be av_freep)
it adds an av_log()
and it drops handling of the byte array case

i guess you should send 4 patches, this would avoid misundderstandings
(if->switch rejected)
(av_log needs +1 line)
(av_free needs +1 line)
(byte arary change +0 line)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100221/179bb085/attachment.pgp>