[FFmpeg-devel] Bug in the mpeg-ts writer code
belcampo
belcampo
Fri Feb 19 10:52:07 CET 2010
Yann Coupin wrote:
> On Thu, Feb 18, 2010 at 1:37 AM, Baptiste Coudurier <
> baptiste.coudurier at gmail.com> wrote:
>
>> I should have mentioned that it is not problematic at all. I said that I'd
>> prefer if it would start at 0 because in the perfect scenario of a complete
>> file, it seems natural for the cc to start at 0.
>>
>>
> Here's a new version of the patch that generates files with a cc that starts
> at 0. It validates as far as I can tell. I've updated the checksum for the
> regression testing accordingly.
>
> Yann
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
I tried your patch and it gives on 1 sample a > 28% size increase in
comparison to tsMuxeR, 1553256000 vs. 1211038096.
On a PopCornHour the file doesn't play, where the 'tsMuxeR' version
plays well. A jump to 10% of the file jumps to the ~80% position.
Mediainfo
diff -u ffmpeg tsMuxeR
--- ffmpeg 2010-02-19 10:46:43.592520034 +0100
+++ tsMuxeR 2010-02-19 10:46:55.056551291 +0100
@@ -8,39 +8,36 @@
ID : 1
Count of video streams : 1
Count of audio streams : 1
-Count of menu streams : 1
Video_Format_List : AVC
Video_Format_WithHint_List : AVC
Codecs Video : AVC
Audio_Format_List : AAC
Audio_Format_WithHint_List : AAC
Audio codecs : AAC LC
-Menu_Format_List : AVC / AAC
-Menu_Format_WithHint_List : AVC / AAC
-Menu codecs : AVC / A_AAC/MPEG4/LC
-Menu_Language_List : /
-Complete name : 8904_20100219002500.ts
-File name : 8904_20100219002500.ts
+Complete name : 8904_20100219002500-2.ts
+File name : 8904_20100219002500-2.ts
File extension : ts
Format : MPEG-TS
Format : MPEG-TS
Codec : MPEG-TS
Codec : MPEG-TS
-File size : 1553256000
-File size : 1.45 GiB
+File size : 1211038096
+File size : 1.13 GiB
File size : 1 GiB
-File size : 1.4 GiB
-File size : 1.45 GiB
-File size : 1.447 GiB
-Duration : 5581200
-Duration : 1h 33mn
-Duration : 1h 33mn 1s 200ms
-Duration : 1h 33mn
-Duration : 01:33:01.200
-Overall bit rate : 2226411
-Overall bit rate : 2 226 Kbps
-File last modification date : UTC 2010-02-19 09:18:11
-File last modification date (loc : 2010-02-19 10:18:11
+File size : 1.1 GiB
+File size : 1.13 GiB
+File size : 1.128 GiB
+Duration : 5581400
+Duration : 1h 33mn
+Duration : 1h 33mn 1s 400ms
+Duration : 1h 33mn
+Duration : 01:33:01.400
+Overall bit rate : 1735819
+Overall bit rate : 1 736 Kbps
+Maximum Overall bit rate : 35500000
+Maximum Overall bit rate : 35.5 Mbps
+File last modification date : UTC 2010-02-19 09:25:34
+File last modification date (loc : 2010-02-19 10:25:34
Video
Count : 148
@@ -48,8 +45,8 @@
Kind of stream : Video
Kind of stream : Video
Stream identifier : 0
-ID : 256
-ID : 256 (0x100)
+ID : 4113
+ID : 4113 (0x1011)
Menu ID : 1
Menu ID : 1 (0x1)
Format : AVC
@@ -70,11 +67,11 @@
Codec settings : CABAC / 2 Ref Frames
Codec settings, CABAC : Yes
Codec_Settings_RefFrames : 2
-Duration : 5581200
+Duration : 5581480
Duration : 1h 33mn
-Duration : 1h 33mn 1s 200ms
+Duration : 1h 33mn 1s 480ms
Duration : 1h 33mn
-Duration : 01:33:01.200
+Duration : 01:33:01.480
Nominal bit rate : 1672000
Nominal bit rate : 1 672 Kbps
Width : 720
@@ -86,7 +83,7 @@
Display aspect ratio : 16:9
Frame rate : 25.000
Frame rate : 25.000 fps
-Frame count : 139530
+Frame count : 139537
Standard : PAL
Resolution : 24
Resolution : 24 bits
@@ -96,16 +93,17 @@
Interlacement : PPF
Interlacement : Progressive
Bits/(Pixel*Frame) : 0.161
-Delay : 700
-Delay : 700ms
-Delay : 700ms
-Delay : 700ms
-Delay : 00:00:00.700
+Delay : 600000
+Delay : 10mn 0s
+Delay : 10mn 0s 0ms
+Delay : 10mn 0s
+Delay : 00:10:00.000
Writing library : x264 - core 65 r0+999 cc51047
Writing library : x264 core 65 r0+999 cc51047
Writing library/Name : x264
Writing library/Version : core 65 r0+999 cc51047
Encoding settings : cabac=1 / ref=2 / deblock=1:0:0 /
analyse=0x3:0x113 / me=umh / subme=4 / psy_rd=0.0:0.0 / mixed_ref=1 / me
_range=16 / chroma_me=1 / trellis=0 / 8x8dct=1 / cqm=0 / deadzone=21,11
/ chroma_qp_offset=0 / threads=1 / nr=0 / decimate=1 / mbaff=0 / bfram
es=0 / keyint=250 / keyint_min=25 / scenecut=40 / rc=abr / bitrate=1672
/ ratetol=2.4 / qcomp=0.50 / qpmin=22 / qpmax=27 / qpstep=3 / ip_ratio
=1.25 / aq=1:1.00
+BufferSize : 3750000
Audio
Count : 129
@@ -113,8 +111,8 @@
Kind of stream : Audio
Kind of stream : Audio
Stream identifier : 0
-ID : 257
-ID : 257 (0x101)
+ID : 4352
+ID : 4352 (0x1100)
Menu ID : 1
Menu ID : 1 (0x1)
Format : AAC
@@ -126,57 +124,26 @@
Codec : AAC LC
Codec/Family : AAC
Codec/Info : AAC Low Complexity
-Duration : 5581162
+Duration : 5581269
Duration : 1h 33mn
-Duration : 1h 33mn 1s 162ms
+Duration : 1h 33mn 1s 269ms
Duration : 1h 33mn
-Duration : 01:33:01.162
+Duration : 01:33:01.269
Bit rate mode : VBR
Bit rate mode : Variable
Channel(s) : 2
Channel(s) : 2 channels
Sampling rate : 48000
Sampling rate : 48.0 KHz
-SamplingCount : 267895776
+SamplingCount : 267900912
Resolution : 16
Resolution : 16 bits
-Delay : 721
-Delay : 721ms
-Delay : 721ms
-Delay : 721ms
-Delay : 00:00:00.721
-Video delay : 21
-Video delay : 21ms
-Video delay : 21ms
-Video delay : 21ms
-Video delay : 00:00:00.021
-Video0 delay : 21
-Video0 delay : 21ms
-Video0 delay : 21ms
-Video0 delay : 21ms
-Video0 delay : 00:00:00.021
-
-Menu
-Count : 47
-Count of stream of this kind : 1
-Kind of stream : Menu
-Kind of stream : Menu
-Stream identifier : 0
-ID : 4095
-ID : 4095 (0xFFF)
-Menu ID : 1
-Menu ID : 1 (0x1)
-Format : AVC / AAC
-Codec : AVC / A_AAC/MPEG4/LC
-Codec : AVC / A_AAC/MPEG4/LC
-List_StreamKind : 1 / 2
-List_StreamPos : 0 / 0
-List : 256 / 257
-List : 256 (0x100) (AVC) / 257 (0x101) (AAC)
-Language : /
-Language : /
-Service name : Service01
-Service provider : FFmpeg
-Service type : digital television
+Delay : 600000
+Delay : 10mn 0s
+Delay : 10mn 0s 0ms
+Delay : 10mn 0s
+Delay : 00:10:00.000
+Video delay : 0
+Video0 delay : 0
More information about the ffmpeg-devel
mailing list