[FFmpeg-devel] [PATCH] enc is not a good name for a decoder context

[Stefano Sabatini]

On date Wednesday 2009-12-30 00:14:31 +0100, Stefano Sabatini encoded:
> On date Tuesday 2009-12-29 01:21:13 +0100, Michael Niedermayer encoded:
> > On Mon, Dec 28, 2009 at 11:30:07PM +0100, Stefano Sabatini wrote:
> > > On date Monday 2009-12-28 23:19:59 +0100, Michael Niedermayer encoded:
> > > > On Mon, Dec 28, 2009 at 10:56:25PM +0100, Stefano Sabatini wrote:
> > > > > Hi, as in subject.
> > > > > 
> > > > > Regards.
> > > > > -- 
> > > > > FFmpeg = Friendly and Foolish Multimedia Portable Ecstatic Geek
> > > > 
> > > > >  ffplay.c |   68 +++++++++++++++++++++++++++++++--------------------------------
> > > > >  1 file changed, 34 insertions(+), 34 deletions(-)
> > > > > b9e8704744f4cf2e98f3451c6e34c3d75385c30f  ffplay-use-better-name-for-decoder-ctx.patch
> > > > > Index: ffplay.c
> > > > > ===================================================================
> > > > > --- ffplay.c	(revision 20954)
> > > > > +++ ffplay.c	(working copy)
> > > > > @@ -1692,50 +1692,50 @@ static void sdl_audio_callback(void *opaque, Uint8
> > > > >  static int stream_component_open(VideoState *is, int stream_index)
> > > > >  {
> > > > >      AVFormatContext *ic = is->ic;
> > > > > -    AVCodecContext *enc;
> > > > > +    AVCodecContext *dec;
> > > > 
> > > > dec is not a good name for AVCodecContext either
> > > 
> > > dec_ctx?
> > > decoder_ctx?
> > > codec_ctx?
> > 
> > avctx
> 
> Mmh.. no I don't believe that's a good name either, try to ask what
> that could mean to someone which never looked at the FFmpeg source...
> dec_ctx or even codec_ctx are way more intelligible names IMO...

Ping?
-- 
FFmpeg = Fascinating Fiendish Minimalistic Powerful Ephemeral Gadget