[FFmpeg-devel] [PATCH] Fix inclusion in pixdesc.h of the non-public header intreadwrite.h

Michael Niedermayer michaelni
Mon Feb 15 02:14:51 CET 2010

On Sun, Feb 14, 2010 at 11:39:35PM +0100, Stefano Sabatini wrote:
> Hi all,
> intreadwrite.h is not public so we should not include it in a public
> header, this also fixes a bunch of warnings during compilation.
> Also read_line() and write_line() are just meant for
> testing/debugging/pedagogical purposes, so the fact that they're not
> defined inline shouldn't be relevant.

no, read/write_line() are an essential and important part of pixdescs
They where intended as fallback for very rarely used convertions in swscale
having a specific optimized converter for each pixel format is overkill
especially on CONFIG_SMALL targets


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100215/e5f540a5/attachment.pgp>

More information about the ffmpeg-devel mailing list