[FFmpeg-devel] [PATCH]set lavf ident string globally

Anton Khirnov wyskas
Sun Feb 14 16:04:18 CET 2010


On Sun, Feb 14, 2010 at 11:29:17AM +0100, Michael Niedermayer wrote:
> 
> grep '_build\W' libavcodec/*.c
> 
yeah that's decoders. my patch only affects muxing and no demuxer does this.

> 
> 
> you can write it twice, not writing it is the problem
> 
might be, my point is that treating 'encoder' as a special case makes
the code more complicated than necessary => more prone to errors.

> 
> does your patch change the regression test checksums?
> 
no since regtests set bitexact flag. i've tested this manually though
and avi muxer produces identical files both with and without the patch.
mp3 muxer doesn't because with the patch TSSE frame is correctly written
only once.

Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100214/a213eee9/attachment.pgp>



More information about the ffmpeg-devel mailing list