[FFmpeg-devel] [PATCH] Add writing of vorbis comments to flac files

James Darnley james.darnley
Sun Feb 14 13:01:54 CET 2010


On 14 February 2010 11:23, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Feb 14, 2010 at 09:10:35AM +0100, Reimar D?ffinger wrote:
>> On Sat, Feb 13, 2010 at 08:13:45PM -0500, Justin Ruggles wrote:
>> > If the bitexact flag is set, you should pass NULL instead of m so that
>> > tags are not written.
>>
>> I disagree, with bitexact no version-specific flags or similar should be created,
>> but tags in general should be created, otherwise we can never regression-test
>> that code.
>
> actually we could store a generic "libavformat" without version

I copied what oggenc.c does in this case.  If bitexact is set, it just
writes "ffmpeg" as the vendor string.



More information about the ffmpeg-devel mailing list