[FFmpeg-devel] [PATCH] Add writing of vorbis comments to flac files

James Darnley james.darnley
Sat Feb 13 21:51:38 CET 2010


Another patch for consideration.

On 3 February 2010 18:55, James Darnley <james.darnley at gmail.com> wrote:
>> -ret: 0 ? ? ? ? st: 0 flags:1 dts: NOPTS ? ?pts: NOPTS ? ?pos: ? ? 42
>> size: ?1024
>> +ret: 0 ? ? ? ? st: 0 flags:1 dts: NOPTS ? ?pts: NOPTS ? ?pos: ? 8256
>> size: ?1024

Okay, this seems to be the position of the first frame in the file.
After looking at some other files, this value always pointed to the
first frame.

> Does the AVMetadata system automatically use the following change?
>>r21587 | pross | 2010-02-01 12:39:10 +0100 (Mon, 01 Feb 2010) | 3 lines
>>Add a list of generic tags and change demuxers to follow it.
>>Patch by Anton Khirnov, wyskas at gmail dot com

I tried using various keys but I cannot see that this does much.  So I
added the two removed entries in ff_vorbiscomment_metadata_conv namely
date-year and artist-author.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg_flac-tags_17_r21809M.diff
Type: application/octet-stream
Size: 13317 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100213/b06518b5/attachment.obj>



More information about the ffmpeg-devel mailing list