[FFmpeg-devel] [PATCH] WMA Voice decoder

Michael Niedermayer michaelni
Thu Feb 11 06:56:29 CET 2010

On Wed, Feb 10, 2010 at 10:25:58PM -0500, Ronald S. Bultje wrote:
> Hi,
> On Mon, Feb 1, 2010 at 2:35 PM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> > On Sun, Jan 31, 2010 at 09:46:43PM -0500, Ronald S. Bultje wrote:
> >> On Sat, Jan 30, 2010 at 6:48 PM, Reimar D?ffinger
> >> <Reimar.Doeffinger at gmx.de> wrote:
> >> > "short"? Also specifying the type only once is ugly.
> >> > Also if you use frame_size with a shift they all can be uint8_t
> >> > (though probably it's better to just "waste" those 34 bytes and
> >> > leave frame_size 16 bits, but the others don't need to be.
> >>
> >> OK, so I changed this to be holdable in 32bits per frame type, maybe
> >> that's a bit too much just let me know how far I should go.
> >
> > I'm generally in favour of the most readable, at least as long as we
> > are talking about saving a few _bytes_, if it was a kB that'd be different.
> As we discussed, this is nearing bikeshed-status. It's not
> performance-relevant and small codec binary size would therefore be
> worthy, so I'll leave it as is.

did someone say bikeshed? :)
anyway, when comparing bit vs 4byte dont forget that gcc might need
20+ bytes of code to access this bit so depending on how many of these
bits are there it may or may not be smaller


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100211/2afde213/attachment.pgp>

More information about the ffmpeg-devel mailing list