[FFmpeg-devel] [PATCH] urlconcat protocol

Stefano Sabatini stefano.sabatini-lala
Sat Feb 6 12:28:06 CET 2010


On date Saturday 2010-02-06 07:57:06 +0100, Michele Orr? encoded:
> fixed.
> 
> > +    char *urinod = NULL, *tmpunod;
> >
> > in general is a good idea to define
> > variables only in the block where they're used.
> >
> ISO C90 forbids mixed declarations and code.

Again a naming consideration:
concat.c
URLProtocol urlconcat_protocol = {
"cat",
REGISTER_PROTOCOL (URLCONCAT, urlconcat);

I suggest to use "concat" ("urlconcat" seems too long) for all of
these, should be less confusing.

Regards.
-- 
FFmpeg = Frenzy Frightening Majestic Powerful Epic God



More information about the ffmpeg-devel mailing list