[FFmpeg-devel] [PATCH] Simplify uses{H, V}Filter settings in sws_getContext()

[Michael Niedermayer]

On Wed, Feb 03, 2010 at 10:38:36PM +0100, Stefano Sabatini wrote:
> On date Sunday 2010-01-24 19:04:01 +0100, Stefano Sabatini encoded:
> > Hi, IMO much more readable.
> > 
> > Regards.
> > -- 
> > FFmpeg = Freak and Fundamentalist Murdering Programmable Enlightening Gadget
> 
> > Index: libswscale/utils.c
> > ===================================================================
> > --- libswscale/utils.c	(revision 30425)
> > +++ libswscale/utils.c	(working copy)
> > @@ -858,15 +858,14 @@
> >      c->srcFormatBpp = av_get_bits_per_pixel(&av_pix_fmt_descriptors[srcFormat]);
> >      c->vRounder= 4* 0x0001000100010001ULL;
> >  
> > -    usesHFilter= usesVFilter= 0;
> > -    if (dstFilter->lumV && dstFilter->lumV->length>1) usesVFilter=1;
> > -    if (dstFilter->lumH && dstFilter->lumH->length>1) usesHFilter=1;
> > -    if (dstFilter->chrV && dstFilter->chrV->length>1) usesVFilter=1;
> > -    if (dstFilter->chrH && dstFilter->chrH->length>1) usesHFilter=1;
> > -    if (srcFilter->lumV && srcFilter->lumV->length>1) usesVFilter=1;
> > -    if (srcFilter->lumH && srcFilter->lumH->length>1) usesHFilter=1;
> > -    if (srcFilter->chrV && srcFilter->chrV->length>1) usesVFilter=1;
> > -    if (srcFilter->chrH && srcFilter->chrH->length>1) usesHFilter=1;
> > +    usesVFilter = (dstFilter->lumV && dstFilter->lumV->length>1) ||
> > +                  (dstFilter->chrV && dstFilter->chrV->length>1) ||
> > +                  (srcFilter->lumV && srcFilter->lumV->length>1) ||
> > +                  (srcFilter->chrV && srcFilter->chrV->length>1);
> > +    usesHFilter = (dstFilter->lumH && dstFilter->lumH->length>1) ||
> > +                  (dstFilter->chrH && dstFilter->chrH->length>1) ||
> > +                  (srcFilter->lumH && srcFilter->lumH->length>1) ||
> > +                  (srcFilter->chrH && srcFilter->chrH->length>1);
> 
> Ping?

ENoTimeForReviewingFuckingCosmeticBikeshedPatches :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100204/87d3c0b8/attachment.pgp>