[FFmpeg-devel] [PATCH][0.5] Fix building on the hurd

[Reinhard Tartler]

On Mo, Feb 01, 2010 at 21:22:10 (CET), Reimar D?ffinger wrote:

> On Mon, Feb 01, 2010 at 09:04:52PM +0100, Reinhard Tartler wrote:
>> 
>> Author: Andres Mejia <mcitadel at gmail.com>
>> Fix build failures for the GNU Hurd OS
>> 
>> please approve for branches/0.5
>> 
>> --- a/configure
>> +++ b/configure
>> @@ -1651,6 +1651,9 @@ case $target_os in
>>          ;;
>>      gnu/kfreebsd)
>>          ;;
>> +    gnu)
>> +        disable dv1394
>> +        ;;
>
> How does it fail?

It fails to build.

> There certainly should be a proper autodetection for that feature?
> Actually, considering it only seems to require ioctl and mmap is there
> much of a point to disable this feature?

The hurd does not seem to have firewire support at all. Moreover, the
proposed patch is actually a backport of trunk, and therefore I think it
is valid on its own.

For completeness, I think this is the relevant debian bug report:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=372290. It was reported
by a hurd porter, and I generally tend to trust porters.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4