[FFmpeg-devel] [PATCH 1/2] lavf: add AVOption support for muxers

[Anssi Hannula]

On 29.12.2010 13:40, Stefano Sabatini wrote:
> On date Wednesday 2010-12-29 06:54:14 +0200, Anssi Hannula encoded:
>> ---
>>  libavformat/avformat.h |    2 ++
>>  libavformat/utils.c    |    4 ++++
>>  2 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
>> index c6f2827..9eab2da 100644
>> --- a/libavformat/avformat.h
>> +++ b/libavformat/avformat.h
>> @@ -368,6 +368,8 @@ typedef struct AVOutputFormat {
>>      const AVMetadataConv *metadata_conv;
>>  #endif
>>  
>> +    const AVClass *priv_class; ///< AVClass for the private context
>> +
>>      /* private fields */
>>      struct AVOutputFormat *next;
>>  } AVOutputFormat;
> 
> Put this after the "next" field or it will break ABI (note for the
> committer: bump minor).

Well, I thought the /* private fields */ meant that the lavf internal
variables are last so that they can be added/removed/modified at will
without breaking ABI, which only works if they indeed are the last ones.

But if that is not the intention, priv_class can be put last (it is public).

As for the minor bump, seems I forgot that for this one.

-- 
Anssi Hannula