[FFmpeg-devel] [PATCH] Add av_file_get_size() and av_file_read(), replace cmdutils.h:read_file().

Michael Niedermayer michaelni
Wed Dec 29 02:15:34 CET 2010


On Tue, Dec 28, 2010 at 12:43:30PM +0100, Nicolas George wrote:
> Le septidi 7 niv?se, an CCXIX, Michael Niedermayer a ?crit?:
> > I dont see what is inconventient to write a 10 line av_log_callcack() that
> > passes its strings to thread local storage (if the GUI has a log window
> > per thread) or global storeage through a mutex if theres one window
> 
> Relying on global variables to carry information between parts of the
> program is usually considered very bad design, since it usually leads to
> ugly constructs and lots of bugs, for example maintaining a stack of values
> and forgetting to unstack.

the first parameter of av_log is a context that can hold the stack

[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101229/ee9c02c8/attachment.pgp>



More information about the ffmpeg-devel mailing list