[FFmpeg-devel] [RFC] How to fix DR+lavfi+vflip crash

[Ronald S. Bultje]

Hi,

On Mon, Dec 27, 2010 at 10:41 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Dec 27, 2010 at 11:39:53PM +0100, Stefano Sabatini wrote:
>> On date Monday 2010-12-27 20:14:00 +0100, Michael Niedermayer encoded:
>> > On Mon, Dec 27, 2010 at 07:07:53PM +0100, Stefano Sabatini wrote:
>> > > On date Monday 2010-12-27 18:14:26 +0100, Stefano Sabatini encoded:
>> > > > On date Monday 2010-12-27 16:13:14 +0100, Michael Niedermayer encoded:
>> > > [...]
>> > > > > applied (without typo)
>> > > >
>> > > > Unfortunately can't work with pad, I was too quick to push the button.
>> > >
>> > > Check attached, works for me, but since I've been confused tons of
>> > > times by this problem I prefer to get another look by someone else.
>> >
>> > pad crashes in put_pixels16_sse2() for me on its own and ironically not with
>> > vflip but there are vissual artifacts on the left side
>>
>> put_pixels16_sse2() is assuming some kind of 16-bit alignment for the
>> value in pixels, it doesn't crash when the y pad value is a multiple
>> of 16.
>
> do you plan to put this in the documentation? ;)
>
>
>>
>> > Ill look into this once you fixed pad working without vflip and if its then
>> > still not working with vflip
>>
>> Uh what's this a sort of bargain? The problems look completely
>> unrelated.
>
> It doesnt crash for me with vflip, just without :)
> and you provide no gdb output so theres not much i can do about vflip+pad.
> I do need a reproduceable testcase & gdb output first.
> I can fix pad and alignment if you dont know how to do it ...

Can we please force 16-byte alignment on buffers allocated within lav*?

Ronald