[FFmpeg-devel] [PATCH 2/3] Metadata muxer

[Stefano Sabatini]

On date Tuesday 2010-12-21 13:36:18 +0100, Anton Khirnov encoded:
> On Tue, Dec 21, 2010 at 01:25:59PM +0100, Stefano Sabatini wrote:
> > On date Tuesday 2010-12-21 13:17:52 +0100, Anton Khirnov encoded:
> > > On Sun, Dec 19, 2010 at 03:04:45PM +0100, Stefano Sabatini wrote:
> > > > On date Wednesday 2010-12-15 13:15:13 +0100, Anton Khirnov encoded:
> > > > > Dumps all metadata to a text file for easy manual editing.
> > > > > ---
> > > > >  doc/ffmetadata.txt       |   50 ++++++++++++++++++++++
> > > > >  doc/general.texi         |    2 +
> > > > >  libavformat/Makefile     |    1 +
> > > > >  libavformat/allformats.c |    1 +
> > > > >  libavformat/meta.h       |   29 +++++++++++++
> > > > >  libavformat/metaenc.c    |  102 ++++++++++++++++++++++++++++++++++++++++++++++
> > > > >  6 files changed, 185 insertions(+), 0 deletions(-)
> > > > >  create mode 100644 doc/ffmetadata.txt
> > > > >  create mode 100644 libavformat/meta.h
> > > > >  create mode 100644 libavformat/metaenc.c
> > > > > 
> > > > > diff --git a/doc/ffmetadata.txt b/doc/ffmetadata.txt
> > > > > new file mode 100644
> > > > > index 0000000..d1a545a
> > > > > --- /dev/null
> > > > > +++ b/doc/ffmetadata.txt
> > > > 
> > > > Uhm what about adding a demuxers.texi and muxers.texi file?
> > > I don't see your point, could you elaborate?
> > 
> > I mean that you're implementing a muxer, so I'd expect the its
> > documentation stay in a muxers dedicated file, muxers.texi, like it is
> > done with indevs, outdevs, filters, bitstream filters, etc.
>
> This documentation does not apply to the muxer directly, rather it's a
> definition of a file format. So I think it's better off in a separate
> file, like e.g. snow.txt

Uhm, yes but this is a format which is supposed to be directly edited
by the users, which is not the case for a snow video stream.

Anyway feel free to do as you see it fits, provided that the
documentation is directly accessible through the man pages.
-- 
FFmpeg = Furious and Faithful Meaningless Peaceful Eccentric Gorilla