[FFmpeg-devel] [HACK] fix CAVS decoder crashes

[Michael Niedermayer]

On Sat, Dec 18, 2010 at 01:13:37PM +0100, Reimar D?ffinger wrote:
> On Sat, Dec 18, 2010 at 02:44:40AM +0100, Michael Niedermayer wrote:
> > > @@ -234,7 +234,7 @@
> > >      for(block=0;block<4;block++) {
> > >          d = h->cy + h->luma_scan[block];
> > >          ff_cavs_load_intra_pred_luma(h, top, &left, block);
> > > -        h->intra_pred_l[h->pred_mode_Y[ff_cavs_scan3x3[block]]]
> > > +        h->intra_pred_l[FFMAX(h->pred_mode_Y[ff_cavs_scan3x3[block]], 0)]
> > 
> > as stefan has no time, some comments that might help debuging
> > The intra pred stuff (likely) has to be >= 0 for intra blocks
> > It (likely) is allowed to be negative for non intra blocks
> 
> I don't think so, -1 is the value these are initialized to, meaning
> "not available".

i see nothing unexpected nor contradictioning here


> For normal decoding this gets replaced by a "fallback" value.

where? what value? and what is normal decoding?



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101219/50f8466b/attachment.pgp>