[FFmpeg-devel] [PATCH] common ID3v2 support for all formats

[Reimar Döffinger]

On Sat, Nov 20, 2010 at 05:30:44AM +0100, Michael Niedermayer wrote:
> On Wed, Nov 17, 2010 at 11:07:25PM +0100, Reimar D?ffinger wrote:
> > Ok.
> > However I just stumbled over r17008 which added the
> > "else if(buf0!=p->buf)  return AVPROBE_SCORE_MAX/4-1;".
> > It was supposed to be a hack for large ID3v2 hacks, but it is broken
> > now.
> > However it is even more broken since that condition will trigger for
> > all raw MPEG-ES files and anything else that starts with a 0 byte!
> > So I think it definitely should be removed,
> 
> agree

Finally applied.

> > but I was wondering if
> > it's maybe worth to add a special-case hack to e.g. do
> > "ID3v2 tag and no other format detected -> return mp3 with score 1"
> > or something like that.
> > I don't really like it, but it seems to come up again and again as
> > something users seem to want...
> 
> well if people want it iam not against

Well, I do not really care, but Anton wanted some "better" solution,
so he'll have to speak up whether that helps and he wants it...