[FFmpeg-devel] port mplayer eq filter to libavfilter

[Michael Niedermayer]

On Sat, Dec 04, 2010 at 11:46:13PM +0100, Reimar D?ffinger wrote:
> On Sat, Dec 04, 2010 at 04:01:35PM -0500, Ronald S. Bultje wrote:
> > >> > + ? ? ? ?: "+r" (line), "+m" (h)
> > >> > + ? ? ? ?: "r" (w), "r" (brightness), "r" (contrast), "m" (step)
> > >> > + ? ? ? ?: "%"REG_c, "%"REG_d, "%"REG_a, "memory"
> > >>
> > >> this has some potential to fail on some x86_32 compilers
> > >
> > > if it does fail it can likely be solved by putting the code under #if HAVE_7REGS
> > 
> > Given that the code did not compile under x86-64, I think he tested on
> > x86-32 and thus it should be ok. I can test on OSX if you're scared,
> > but that's what FATE is for no? :-).
> 
> I'm certain nobody tested all compilers, and I am almost certain that
> HAVE_7REGS will _not_ work for this, in the worst case
> (particularly with PIC) there is a good chance this would need 9 registers.

HAVE_7REGS is not set if x86_32 && PIC with gcc

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101205/3005d0b1/attachment.pgp>