[FFmpeg-devel] [PATCH] yadif sse2/ssse3

[Michael Niedermayer]

On Wed, Dec 01, 2010 at 01:28:12AM -0800, Baptiste Coudurier wrote:
> On 11/30/10 4:42 PM, Michael Niedermayer wrote:
> > On Tue, Nov 30, 2010 at 09:33:27AM +0100, Luca Barbato wrote:
> >> On 11/30/2010 05:52 AM, Baptiste Coudurier wrote:
> >>> Hi Michael,
> >>>
> >>> On 11/29/10 4:46 PM, Michael Niedermayer wrote:
> >>>> On Sat, Nov 20, 2010 at 06:32:39PM -0800, Baptiste Coudurier wrote:
> >>>>> Hi guys,
> >>>>>
> >>>>> $subject.
> >>>> [...]
> >>>>     > +#if HAVE_SSE
> >>>>> +    DECLARE_ALIGNED(16, uint8_t, tmp0[16]);
> >>>>> +    DECLARE_ALIGNED(16, uint8_t, tmp1[16]);
> >>>>> +    DECLARE_ALIGNED(16, uint8_t, tmp2[16]);
> >>>>> +    DECLARE_ALIGNED(16, uint8_t, tmp3[16]);
> >>>>> +#else
> >>>>>      uint64_t tmp0, tmp1, tmp2, tmp3;
> >>>>> +#endif
> >>>>
> >>>> This seems unneeded (align always should be fine)
> >>>
> >>> I'm not sure I understand, do you mean I should remove the DECLARE_ALIGNED ?
> >>>
> >>
> >> remove the ifdef and keep the same var declaration (aligned) probably.
> > 
> > yes
> 
> Patch updated.
> 
> -- 
> Baptiste COUDURIER
> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
> FFmpeg maintainer                                  http://www.ffmpeg.org

>  libavcodec/x86/dsputil_mmx.c     |    1 
>  libavfilter/vf_yadif.c           |    6 
>  libavfilter/x86/yadif.c          |  228 ++-------------------------------
>  libavfilter/x86/yadif_template.c |  268 +++++++++++++++++++++++++++++++++++++++
>  libavfilter/yadif.h              |    8 +
>  5 files changed, 301 insertions(+), 210 deletions(-)
> 2cfc22ed7b528bb37a526b5ae96e11ec99775f38  yadif_sse.patch

lgtm if tested

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101203/acad4d85/attachment.pgp>